buffer: add opaque fast-path in setCellWithAlphaBlending #500
+22
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most rendered cells are fully opaque, yet the blending path unconditionally calls get() + blendCells() for every cell. This commit adds an opaque check to skip blending in the common case. For the raw variant, the only caller is the graphemeAware=false branch in drawFrameBuffer, so grapheme chars should never appear. I made this contract explicit by replacing the grapheme fallback with debug asserts, avoiding per-cell overhead in release builds.
simonklee
force-pushed
the
buffer-opaque-fast-path
branch
from
71f414b to
14782a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most rendered cells are fully opaque, yet the blending path unconditionally calls get() + blendCells() for every cell.
This adds an opaque check to skip blending in the common case.
For the raw variant, the only caller is the graphemeAware=false branch in drawFrameBuffer, so grapheme chars should never appear. I made this contract explicit by replacing the grapheme fallback with debug asserts, avoiding per-cell overhead in release builds.